Add CI to check that the provider compiles #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added
the
impact/no-changelog-required
iwahbe
force-pushed
the
iwahbe/check-provider-compiles-in-ci
branch
4 times, most recently
from
78c9681
to
020474b
Compare
This is necessary to prevent regressions like #101.
iwahbe
force-pushed
the
iwahbe/check-provider-compiles-in-ci
branch
from
020474b
to
9f1974e
Compare
iwahbe
changed the title
iwahbe
commented
Dec 27, 2023
| - lll | ||
| - megacheck | ||
| - misspell | ||
| - nakedret | ||
| - structcheck | ||
| - revive |
There was a problem hiding this comment.
The changes here allow the linter to trigger without warnings on deprecated linters.
thomas11
approved these changes
Dec 27, 2023
| run: | | ||
| git grep -l 'go:embed' -- provider | xargs sed -i 's/go:embed/ goembed/g' | ||
| - name: prepare upstream | ||
| continue-on-error: true |
There was a problem hiding this comment.
Because the Makefile might not define an upstream target. If it does, then it is assumed to be necessary to compile the provider. If make upstream exists and fails, it is assumed the next step will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the hypothetical provider to an actual empty provider so the template compiles as is. It then checks compilation by running golangci-lint on the provider.
Compile failures will now fail CI.
Inspired by #101